Extract remaining preset pass manager stages into plugins #8661
Labels
mod: transpiler
Issues and PRs related to Transpiler
short project
type: epic
A theme of work that contain sub-tasks
type: feature request
New feature or request
Milestone
Comments
mtreinish
added
type: feature request
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this issue
Aug 22, 2023
This commit updates the preset pass manager construction to only use plugins for the init stage. To accomplish this the previously hard coded built-in pass manager used for each optimization level are refactored to be in a plugin named "default". One thing that is changed in this PR is that the use of `generate_control_flow_options_check()` is moved to the `pre_init` stage. The reason for this is because the way the init stage was being constructed in the preset pass managers was to do initial checking of any methods, and this was unconditionally being run. This is a more logical fit for pre_init stage because it should run before any specified plugin. Fixes: Qiskit#10687 Fixes: Qiskit#8661
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 22, 2023
This commit updates the preset pass manager construction to only use plugins for the init stage. To accomplish this the previously hard coded built-in pass manager used for each optimization level are refactored to be in a plugin named "default". One thing that is changed in this PR is that the use of `generate_control_flow_options_check()` is moved to the `pre_init` stage. The reason for this is because the way the init stage was being constructed in the preset pass managers was to do initial checking of any methods, and this was unconditionally being run. This is a more logical fit for pre_init stage because it should run before any specified plugin. Fixes: #10687 Fixes: #8661
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this issue
Sep 7, 2023
This commit updates the preset pass manager construction to only use plugins for the init stage. To accomplish this the previously hard coded built-in pass manager used for each optimization level are refactored to be in a plugin named "default". One thing that is changed in this PR is that the use of `generate_control_flow_options_check()` is moved to the `pre_init` stage. The reason for this is because the way the init stage was being constructed in the preset pass managers was to do initial checking of any methods, and this was unconditionally being run. This is a more logical fit for pre_init stage because it should run before any specified plugin. Fixes: Qiskit#10687 Fixes: Qiskit#8661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What should we add?
In #8305 we added a new plugin interface for transpiler stages in the preset passmanagers. As part of that PR we migrated the built in routing stage options to be plugins. As a follow up we should continue to expand our internal use of the plugin interface to run the other transpiler stages. This will simplify the maintenance and reuse of the transpiler stages and also ensure we're testing the full path of the plugin interface.
The list of stages to be extracted into plugins:
layoutstage (trivial, dense, sabre, noise_adaptive) plugin #9455translationstage (translator, synthesis, unroller) plugins #9456optimizationstage (there is a different PM for each optimization level) plugins #9457schedulingstage (alap, asap) plugins #9458initstage default plugin #10687The text was updated successfully, but these errors were encountered: