Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create layout stage (trivial, dense, sabre, noise_adaptive) plugin #9455

Closed
Tracked by #8661
mtreinish opened this issue Jan 25, 2023 · 0 comments · Fixed by #10622
Closed
Tracked by #8661

Create layout stage (trivial, dense, sabre, noise_adaptive) plugin #9455

mtreinish opened this issue Jan 25, 2023 · 0 comments · Fixed by #10622
Labels
help wanted community contributions welcome. For filters like http://github-help-wanted.com/

Comments

@mtreinish
Copy link
Member

mtreinish commented Jan 25, 2023 •
edited
Loading

Create a plugin for the builtin layout stage methods. One particular oddity for this stage is it's not just the straight methods, but also a default method will be needed. The default stage will integrate vf2layout (and initial layout too for level 1).
@mtreinish mtreinish mentioned this issue Jan 25, 2023
Closed
5 tasks
@mtreinish mtreinish changed the title layout stage (trivial, dense, sabre, noise_adaptive) Create layout stage (trivial, dense, sabre, noise_adaptive) plugin Jan 25, 2023
@mtreinish mtreinish added the help wanted community contributions welcome. For filters like http://github-help-wanted.com/ label Jan 25, 2023
@github-project-automation github-project-automation bot moved this to Tagged but unassigned in Contributor Monitoring Jan 26, 2023
mtreinish added a commit to mtreinish/qiskit-core that referenced this issue Aug 14, 2023
@mtreinish
Migrate layout stage to plugins
a3c08d8 
This commit updates the preset pass manager construction to only use
plugins for the layout stage. To accomplish this the previously hard
coded built-in layout methods, trivial, dense, noise adpative, and
sabre are migrated to be exposed as built-in plugins. Additionally, the
special case of layout_method=None has been centralized into a standard
default method plugin, as the pass construction in this case involved
extra steps for each optimization level. This simplifies the preset pass
manager construction as now the layout stage is solely built via
plugins.

Fixes Qiskit#9455
@mtreinish mtreinish mentioned this issue Aug 14, 2023
Merged
@github-project-automation github-project-automation bot moved this from Tagged but unassigned to Done in Contributor Monitoring Aug 22, 2023
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2023
@mtreinish
Migrate layout stage to plugins (#10622)
b039687 
* Migrate layout stage to plugins

This commit updates the preset pass manager construction to only use
plugins for the layout stage. To accomplish this the previously hard
coded built-in layout methods, trivial, dense, noise adpative, and
sabre are migrated to be exposed as built-in plugins. Additionally, the
special case of layout_method=None has been centralized into a standard
default method plugin, as the pass construction in this case involved
extra steps for each optimization level. This simplifies the preset pass
manager construction as now the layout stage is solely built via
plugins.

Fixes #9455

* Remove unnecessary if statement

* Handle invalid optimization levels in plugins

* Remove unused variable post-rebase
SamD-1998 pushed a commit to SamD-1998/qiskit-terra that referenced this issue Sep 7, 2023
@mtreinish @SamD-1998
Migrate layout stage to plugins (Qiskit#10622)
60583f2 
* Migrate layout stage to plugins

This commit updates the preset pass manager construction to only use
plugins for the layout stage. To accomplish this the previously hard
coded built-in layout methods, trivial, dense, noise adpative, and
sabre are migrated to be exposed as built-in plugins. Additionally, the
special case of layout_method=None has been centralized into a standard
default method plugin, as the pass construction in this case involved
extra steps for each optimization level. This simplifies the preset pass
manager construction as now the layout stage is solely built via
plugins.

Fixes Qiskit#9455

* Remove unnecessary if statement

* Handle invalid optimization levels in plugins

* Remove unused variable post-rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted community contributions welcome. For filters like http://github-help-wanted.com/
Projects
Contributor Monitoring
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate layout stage to plugins mtreinish/qiskit-core
1 participant
@mtreinish