Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Add/fix additions to release notes for recent release 0.43.1 #1754

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

jlapeyre
Copy link
Collaborator

@jlapeyre jlapeyre commented Jun 5, 2023

The release notes for the most recent release did not follow the required template. This PR provides a fix.

Release 0.43.1 was made for this package because Terra 0.24.1 was released. See PR #1753.

The release notes for the most recent release did not follow the required
template. This PR provides a fix.

Release 0.43.1 was made for this package because Terra 0.24.1 was released.
See PR #1753.
Eric-Arellano
Eric-Arellano previously approved these changes Jun 5, 2023
@Eric-Arellano Eric-Arellano added the automerge This PR will automatically merge once its CI has passed label Jun 5, 2023
@jakelishman jakelishman removed the automerge This PR will automatically merge once its CI has passed label Jun 5, 2023
Comment on lines 30 to 31
Terra 0.24.1
======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underline needs expanding - it's an rST warning to have a too-short underline (but I think it's permissible to be too long - it's kind of weird).

Copy link
Collaborator Author

@jlapeyre jlapeyre Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why it should not be required to be exactly the same length as the text.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No me neither, but weirdly the spec explicitly says they can be longer.

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Fortunately, we're in the last throes of needing to screw around with this document - once the metapackage is properly retired, we'll be able to use the more standard reno workflows from within Terra.

@jakelishman jakelishman added the automerge This PR will automatically merge once its CI has passed label Jun 5, 2023
@mergify mergify bot merged commit 5f9e094 into master Jun 5, 2023
@Eric-Arellano Eric-Arellano deleted the fix-release-notes-0.43.1 branch June 5, 2023 15:41
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
…qiskit-metapackage#1754)

The release notes for the most recent release did not follow the
required template. This PR provides a fix.

Release 0.43.1 was made for this package because Terra 0.24.1 was
released. See PR Qiskit/qiskit-metapackage#1753.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge This PR will automatically merge once its CI has passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants