-
Notifications
You must be signed in to change notification settings - Fork 749
Make changes to bump version #1753
Conversation
No, the reno report includes a heading that must be omitted when pasting in |
I clicked the "squash and merge" button. But there was no opportunity (that I saw) to squash. So the commit message of the merge commit is not descriptive of the tagged version. |
It squash merged, but we need to fix our config for this repo so that squash merge defaults to the PR Title And Description. I'm not an admin so haven't been able to.
No, I think you're fine. The commit message itself isn't that crucial because we have the Git tag and GitHub releases to make it clear that that single squashed commit is where the release happened. I doubt many people are looking at the commit message, and instead they care about the tag and GitHub Release. |
Ok. I'll just tag what we have. (I responded to you in two minutes, and late last night within 5 minutes. That is fortuitous. I'm not staring at this PR day and night) |
.. _Release Notes_Terra_0.24.1: | ||
|
||
0.24.1 | ||
====== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite right - we ought to have modified the title to say "Terra 0.24.1", and to have included
Aer 0.12.0
==========
No change.
IBMQ Provider 0.x.y
===================
No change.
below. We can just fix this up though, even if the metapackage was already deployed - it'll just get folded into the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct. Can this be fixed up with this release? I don't see how. Maybe retroactively fix it along with the next bugfix release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make changes to the docs whenever, and they'll get deployed as-and-when. The main qiskit.org/documentation
page should get updated immediately with new files from this repo, unless the process has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is still correct that we deploy docs on every merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Eric. John, would you be able to make a new PR fixing things up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll make a new PR.
The release notes for the most recent release did not follow the required template. This PR provides a fix. Release 0.43.1 was made for this package because Terra 0.24.1 was released. See PR #1753.
The release notes for the most recent release did not follow the required template. This PR provides a fix. Release 0.43.1 was made for this package because Terra 0.24.1 was released. See PR #1753. <!--⚠️ If you do not respect this template, your pull request will be closed.⚠️ Your pull request title should be short detailed and understandable for all.⚠️ Also, please add it in the CHANGELOG file under Unreleased section.⚠️ If your pull request fixes an open issue, please link to the issue. ✅ I have added the tests to cover my changes. ✅ I have updated the documentation accordingly. ✅ I have read the CONTRIBUTING document. -->
…qiskit-metapackage#1754) The release notes for the most recent release did not follow the required template. This PR provides a fix. Release 0.43.1 was made for this package because Terra 0.24.1 was released. See PR Qiskit/qiskit-metapackage#1753.
Bump version to 0.43.11
Summary
Details and comments