Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Make changes to bump version #1753

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Make changes to bump version #1753

merged 2 commits into from
Jun 3, 2023

Conversation

jlapeyre
Copy link
Collaborator

@jlapeyre jlapeyre commented Jun 2, 2023

Bump version to 0.43.11

Summary

Details and comments

Eric-Arellano
Eric-Arellano previously approved these changes Jun 2, 2023
@jlapeyre
Copy link
Collaborator Author

jlapeyre commented Jun 2, 2023

No, the reno report includes a heading that must be omitted when pasting in Looks like some doc text may have been pasted twice. Checking ...

@jlapeyre jlapeyre merged commit a9521e6 into master Jun 3, 2023
@Eric-Arellano Eric-Arellano deleted the bump_meta branch June 3, 2023 03:16
@jlapeyre
Copy link
Collaborator Author

jlapeyre commented Jun 3, 2023

I clicked the "squash and merge" button. But there was no opportunity (that I saw) to squash. So the commit message of the merge commit is not descriptive of the tagged version.
I'm reluctant to tag this commit with the new version and release.
Probably better to make a clean commit history on monday and tag the last commit.

@Eric-Arellano
Copy link
Collaborator

I clicked the "squash and merge" button. But there was no opportunity (that I saw) to squash. So the commit message of the merge commit is not descriptive of the tagged version.

It squash merged, but we need to fix our config for this repo so that squash merge defaults to the PR Title And Description. I'm not an admin so haven't been able to.

I'm reluctant to tag this commit with the new version and release.
Probably better to make a clean commit history on monday and tag the last commit.

No, I think you're fine. The commit message itself isn't that crucial because we have the Git tag and GitHub releases to make it clear that that single squashed commit is where the release happened. I doubt many people are looking at the commit message, and instead they care about the tag and GitHub Release.

@jlapeyre
Copy link
Collaborator Author

jlapeyre commented Jun 3, 2023

Ok. I'll just tag what we have. (I responded to you in two minutes, and late last night within 5 minutes. That is fortuitous. I'm not staring at this PR day and night)

Comment on lines +28 to +31
.. _Release Notes_Terra_0.24.1:

0.24.1
======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right - we ought to have modified the title to say "Terra 0.24.1", and to have included

Aer 0.12.0
==========

No change.


IBMQ Provider 0.x.y
===================

No change.

below. We can just fix this up though, even if the metapackage was already deployed - it'll just get folded into the documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct. Can this be fixed up with this release? I don't see how. Maybe retroactively fix it along with the next bugfix release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make changes to the docs whenever, and they'll get deployed as-and-when. The main qiskit.org/documentation page should get updated immediately with new files from this repo, unless the process has changed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is still correct that we deploy docs on every merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric. John, would you be able to make a new PR fixing things up?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'll make a new PR.

jlapeyre added a commit that referenced this pull request Jun 5, 2023
The release notes for the most recent release did not follow the required
template. This PR provides a fix.

Release 0.43.1 was made for this package because Terra 0.24.1 was released.
See PR #1753.
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
The release notes for the most recent release did not follow the
required template. This PR provides a fix.

Release 0.43.1 was made for this package because Terra 0.24.1 was
released. See PR #1753.

<!--
⚠️ If you do not respect this template, your pull request will be
closed.
⚠️ Your pull request title should be short detailed and understandable
for all.
⚠️ Also, please add it in the CHANGELOG file under Unreleased section.
⚠️ If your pull request fixes an open issue, please link to the issue.

✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.
-->
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
…qiskit-metapackage#1754)

The release notes for the most recent release did not follow the
required template. This PR provides a fix.

Release 0.43.1 was made for this package because Terra 0.24.1 was
released. See PR Qiskit/qiskit-metapackage#1753.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants