Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Add instructions on how to create a provider #131

Merged
merged 41 commits into from
Feb 21, 2019
Merged

Add instructions on how to create a provider #131

merged 41 commits into from
Feb 21, 2019

Conversation

derivation
Copy link
Contributor

fixes #123

derivation and others added 30 commits February 13, 2019 13:36
and all references to these images
Motivation: to synthesize the mostly duplicate install instructions currently under each Qiskit element's doc section, which can then be removed.

Direct to CONTRIBUTING files in each element's repo for instructions to build from source, since this serves a niche persona and is lengthy.

Added images for steps that involve pointing and clicking through the web.

Rewrote material for additional clarity.
@derivation derivation requested a review from yaelbh February 21, 2019 00:13
@yaelbh
Copy link
Contributor

yaelbh commented Feb 21, 2019

The Hadamard results printed at the end are not correct. As in the create_a_provider tutorial, they have to be identical to the Aer results two rows below. I don't understand how this happened - I went over the code and it looks identical to the code in create_a_provider. Do you have an idea what can be the cause? If not then I'll try to take another look.

@yaelbh
Copy link
Contributor

yaelbh commented Feb 21, 2019

In the description of the Job class, result and status are listed as properties, although they are functions. In addition, the statement that HadamardJob performs cancel and submit may be confusing; it has empty implementations of these functions.

@yaelbh
Copy link
Contributor

yaelbh commented Feb 21, 2019

Please be aware that the code works with Terra 0.7 and Aer 0.1 (and not necessarily with the master branches of Aer and Terra).

@derivation
Copy link
Contributor Author

derivation commented Feb 21, 2019

Thank you for your careful review @yaelbh (:

Please be aware that the code works with Terra 0.7 and Aer 0.1 (and not necessarily with the master branches of Aer and Terra).

I tested the code with Terra 0.8.0 and Aer 0.1.1, and it still works. Are you anticipating it no longer working soon based on a dev roadmap?

The Hadamard results printed at the end are not correct.

I introduced a bug when I removed a few lines of code. Had the effect of appending qubits being measured with this line of code:

list_of_qubits.append(operation.qubits[0])

Fixed by ensuring only Hadamard operations get picked out as passed arguments above.

In the description of the Job class, result and status are listed as properties, although they are functions. In addition, the statement that HadamardJob performs cancel and submit may be confusing; it has empty implementations of these functions.

Fixed the above.

@derivation derivation self-assigned this Feb 21, 2019
@derivation
Copy link
Contributor Author

@diego-plan9 could you approve / merge this?

Copy link
Member

@diego-plan9 diego-plan9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, thanks @derivation and @yaelbh !

@derivation derivation merged commit 8c6a5db into Qiskit:master Feb 21, 2019
@yaelbh
Copy link
Contributor

yaelbh commented Feb 21, 2019

I tested the code with Terra 0.8.0 and Aer 0.1.1, and it still works. Are you anticipating it no longer working soon based on a dev roadmap?

No, but it has to be verified with every new version.

jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
…ge#131)

* moved Aer tutorial images to /docs/images/figures/

and all references to these images

* Have Makefile point to correct Aqua and Chemistry directories

Fixes Qiskit/qiskit-metapackage#88

* Revert "Have Makefile point to correct Aqua and Chemistry directories"

This reverts commit fee13ba87e1888c88a997430ee0a57969a9985ac.

* Create community_qiskit.rst

* Revert "Create community_qiskit.rst"

This reverts commit 5fd2cafd6d2e570488e9985f26d33a0f5088c581.

* update global install instructions

Motivation: to synthesize the mostly duplicate install instructions currently under each Qiskit element's doc section, which can then be removed.

Direct to CONTRIBUTING files in each element's repo for instructions to build from source, since this serves a niche persona and is lengthy.

Added images for steps that involve pointing and clicking through the web.

Rewrote material for additional clarity.

* removed Troubleshooting section

fixes Qiskit/qiskit-metapackage#97

* simplify the ibm q provider documentation

Fixes Qiskit/qiskit-metapackage#86

* removed Visualizations from global ToC, honed Installing QIskit

Fixes Qiskit/qiskit-metapackage#107 and fixes Qiskit/qiskit-metapackage#95

* added Contributin to Qiskit

fixes Qiskit/qiskit-metapackage#112

* remove Aer install instructions

fixes Qiskit/qiskit-metapackage#84

* Have the ToC do the work, instead of a landing page for Getting Started.

fixes Qiskit/qiskit-metapackage#84

* circuit drawing style in Getting Started

begins to address Qiskit/qiskit-metapackage#98

* adopting the term of art 'quantum cloud services'

* getting_started references wrong circuit drawing PNG file

Fixes Qiskit/qiskit-metapackage#129

* Add instructions on how to create a provider

fixes  Qiskit/qiskit-metapackage#123

* fix a typo in contributing_to_qiskit.rst

* update instructions on how to create a provider

addressing review by @yaelbh

* ipython3 to python code blocks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instructions on how to create a provider
4 participants