Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to take a scan parameter (xval) with each circuit a… #98

Merged
merged 2 commits into from
Oct 6, 2017

Conversation

dcmckayibm
Copy link
Member

Add qubit polarization to results and xval to circuit

Description

  1. Added an xval to the qobj for each circuit for a parameter that can be tracked (e.g. the wait time in a T1)
  2. Added a qubit polarization output to the results which spits out an array giving the qubit polarizations for each circuit.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ewinston ewinston requested review from levbishop and ewinston October 2, 2017 14:29
@ewinston ewinston requested review from chriseclectic and removed request for chriseclectic October 2, 2017 14:30
@ewinston
Copy link
Contributor

ewinston commented Oct 2, 2017

I think a better place for the xval parameter would be in the qobj['circuits'][circuit_index]['config']['xval']=xval or perhaps qobj['config']['xval']=xval_list since it doesn't seem like it's strictly necessary to define a QuantumCircuit.

@dcmckayibm
Copy link
Member Author

dcmckayibm commented Oct 4, 2017

@ewinston I changed it back so that xvals is a dictionary passed to the results function. The only change beyond _results.py is that I updated so that the qobj in compile copies the config that gets passed in.

@ewinston ewinston merged commit a99829b into Qiskit:master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants