Add execution_span.TwirledSliceSpan #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamFerracin
reviewed
Nov 1, 2024
SamFerracin
reviewed
Nov 1, 2024
joshuasn
approved these changes
Nov 1, 2024
jyu00
added
the
Changelog: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This new
ExecutionSpansubclass is added explicitly for the case where a sampler is called with twirling enabled.Details and comments
SliceSpanandDoubleSliceSpanare insufficient because data from twirled experiments is not contiguous in the right way to make them work, especially when batching constants don't magically align with num_randomizations.