Add support for SamplerV2
#507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrison
added
enhancement
Pull Request Test Coverage Report for Build 8395326002Details
💛 - Coveralls |
nbmake < 1.4.3 depends on pydantic < 2.0 (see treebeardtech/nbmake#109), but qiskit-ibm-runtime implicitly requires pydantic > 2.5 (see Qiskit/qiskit-ibm-runtime#1539).
This reverts commit b4de1c2.
This annotation can be removed once qiskit 1.1 is released
garrison
commented
Mar 22, 2024
Comment on lines
-43
to
-47
| subexperiments = [QuantumCircuit(2)] | ||
| creg1 = ClassicalRegister(2, name="observable_measurements") | ||
| creg2 = ClassicalRegister(1, name="qpd_measurements") | ||
| subexperiments[0].add_register(creg1) | ||
| subexperiments[0].add_register(creg2) |
There was a problem hiding this comment.
There was some unnecessary code in this file that I removed. (subexperiments is constructed but then never used anywhere.)
caleb-johnson
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488.
This
is waiting onrequires one of the following before we can move forward (EDIT: the first item is now done!).BackendSamplerV2fails to run with empty classical register qiskit#12043To-do list:
PrimitiveResulttest intest/cutting/test_cutting_reconstruction.py