Add support for SingleQubitQPDGate to be passed through the transpiler
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5480045219
💛 - Coveralls |
| @@ -201,6 +201,11 @@ def _define(self) -> None: | |||
| qc.append(CircuitInstruction(op, [qc.qubits[0]], [])) | |||
| self.definition = qc | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Could you please just quickly explain this mechanism here? Not familiar with _directive
There was a problem hiding this comment.
It is something that @mtreinish told me about. It tells the transpiler to treat it as something special that ought to be passed through most passes without being touched, and is used for Barriers and a few other things.
See this brief description, which itself links to Qiskit/qiskit#5811
mtreinish
reviewed
Jul 6, 2023
#303 (comment) Co-authored-by: Matthew Treinish <[email protected]>
caleb-johnson
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step toward making our workflow more flexible with regard to transpilation. I created a new file for tests like this one. The
_directiveproperty is necessary for this test to pass.