Deprecate decompose_gates #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5256646377
💛 - Coveralls |
caleb-johnson
commented
Jun 5, 2023
garrison
reviewed
Jun 12, 2023
garrison
reviewed
Jun 12, 2023
- skip tests that require pyscf if it is not available - add Windows workflow to Actions matrix - add Windows to README platform badge
This seems to address the root cause of #248. However, I'm not sure why this is necessary, since [the reno documentation](https://docs.openstack.org/reno/latest/user/usage.html#configuring-reno) states "If unset, all versions will be scanned."
Co-authored-by: Jim Garrison <[email protected]>
caleb-johnson
commented
Jun 13, 2023
| package_name="circuit-knitting-toolbox", | ||
| removal_timeline="no earlier than v0.4.0", | ||
| additional_msg=( | ||
| "Instead, use ``circuit_knitting.cutting.cut_gates`` " |
There was a problem hiding this comment.
@garrison do we need back quotes here? Is this strictly a stdio printout, or is this used by sphinx?
There was a problem hiding this comment.
I only included double backquotes because that's what terra did in the opflow deprecation message. If it weren't for that, I probably would have used single backquotes, but nothing is required.
There was a problem hiding this comment.
I actually thought I wrote this out of habit, but thank you for your honesty hah :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #239
This PR deprecates
decompose_gatesin favor ofcut_gates. This change is solely to remove ambiguity between Qiskit's notion of "decompose" and ours.