Fix mypy under rustworkx 0.13.0 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After opening this, I learned that rustworkx 0.13.0 introduced type annotations, but they are currently incomplete. Since this fixes CI, I am in favor of merging it in its current form. |
| @@ -27,7 +27,7 @@ | |||
| from collections.abc import Sequence, Iterable, Hashable, MutableMapping | |||
| from typing import NamedTuple | |||
|
|
|||
| from rustworkx import PyGraph, connected_components | |||
| from rustworkx import PyGraph, connected_components # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
I like this. I wonder how we can know when to remove it? Should we make an issue to keep up with this?
There was a problem hiding this comment.
I wasn't planning to make an issue because I don't think it is worth a strong reminder to fix it. If we notice that rustworkx has more complete type annotations once day and want to revert it, that's fine, but if we don't remember to, it's not really a big deal either.
caleb-johnson
approved these changes
Jun 8, 2023
caleb-johnson
pushed a commit
that referenced
this pull request
Jun 11, 2023
garrison
added a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes mypy when run with the most recent rustworkx release, 0.13.0. Without this, mypy errors with
It's not clear to me, though, why these annotations are necessary. I expect there is a better solution.