Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PySP #1819

Merged
merged 13 commits into from
Feb 16, 2021
Merged

Remove PySP #1819

merged 13 commits into from
Feb 16, 2021

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Feb 16, 2021

Fixes #N/A

Summary/Motivation:

This PR removes PySP from Pyomo, as it is now distributed as a separate package (see https://github.com/Pyomo/pysp).

Note: because this removes PySP, pyomo.contrib.parmest is currently not tested (waiting either for resolution of #1778 or the creation of a GHA job that installs PySP).

Changes proposed in this PR:

  • Remove PySP (code, documentation, and examples)
  • Remove the phpyro solver manager

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@DLWoodruff
Copy link
Contributor

I was planning to work on #1778 on Friday. Recommend merging this PR and then we can verify that #1778 might be an answer.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1819 (58716f8) into master (5afbdfc) will increase coverage by 3.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
+ Coverage   74.93%   78.11%   +3.17%     
==========================================
  Files         638      554      -84     
  Lines       92256    70162   -22094     
==========================================
- Hits        69136    54809   -14327     
+ Misses      23120    15353    -7767     
Impacted Files Coverage Δ
...mo/contrib/parmest/examples/semibatch/semibatch.py 4.51% <0.00%> (-87.97%) ⬇️
pyomo/contrib/parmest/scenariocreator.py 23.43% <0.00%> (-76.57%) ⬇️
pyomo/contrib/parmest/graphics.py 7.74% <0.00%> (-74.54%) ⬇️
.../parmest/examples/rooney_biegler/rooney_biegler.py 0.00% <0.00%> (-72.73%) ⬇️
...o/contrib/parmest/examples/semibatch/scencreate.py 24.13% <0.00%> (-72.42%) ⬇️
.../parmest/examples/reactor_design/reactor_design.py 0.00% <0.00%> (-72.23%) ⬇️
pyomo/opt/parallel/pyro.py 18.34% <0.00%> (-69.73%) ⬇️
pyomo/pysp/__init__.py 33.33% <0.00%> (-66.67%) ⬇️
pyomo/contrib/parmest/parmest.py 11.28% <0.00%> (-61.43%) ⬇️
pyomo/solvers/plugins/smanager/pyro.py 23.01% <0.00%> (-59.53%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afbdfc...67a3e14. Read the comment docs.

@blnicho
Copy link
Member

blnicho commented Feb 16, 2021

PySP is also mentioned in the main Pyomo README. We might want to edit this section:

Further, Pyomo has also proven an effective framework for developing high-level optimization and analysis tools. For example,
the PySP package provides generic solvers for stochastic programming. PySP leverages the fact that Pyomo's modeling objects
are embedded within a full-featured high-level programming language, which allows for transparent parallelization of
subproblems using Python parallel communication libraries.

@mrmundt mrmundt merged commit 1785b31 into Pyomo:master Feb 16, 2021
@jsiirola jsiirola deleted the remove-pysp branch February 16, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants