-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parmest with, or without, mpi-sppy #1778
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
+ Coverage 80.98% 82.15% +1.17%
==========================================
Files 569 571 +2
Lines 71629 71699 +70
==========================================
+ Hits 58008 58904 +896
+ Misses 13621 12795 -826
Continue to review full report at Codecov.
|
…y we really want to ship it (use_mpisppy=True, which means it will try to use mpi-sppy but fall back to local if mpi-sppy is not present)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added minor comments to add the URL to mpi-sppy. Other than that, this looks good to me.
Thanks for making the changes. The one test failure seems to be unrelated to parmest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor questions
if (solver == "k_aug"): | ||
raise RuntimeError("k_aug no longer supported.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to add an issue to support k_aug in the future now that we have easier access to it through idaes-ext
in our testing environment.
Fixes # .
Summary/Motivation: This is a version of parmest that does not need PySP, but can use mpi-sppy if it is present.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: