Issue #2656 #2853
Issue #2656 #2853
Conversation
…is now supported by waitress server.
|
Would you please update the listen directives to support IPv6 interfaces as well, which is the major reason for moving to |
|
Thanks! With the changes that @mmerickel suggested I think this will be good to go! |
|
I think it should be ok now. I've changed docs to shortly explain what |
| @@ -316,12 +317,13 @@ the case, if you use a browser running on the same system as Pyramid, it will | |||
| be able to access the application via ``http://127.0.0.1:6543/`` as well as via | |||
| ``http://192.168.1.50:6543/``. However, *other people* on other computers on | |||
| the same network will also be able to visit your Pyramid application in their | |||
| browser by visiting ``http://192.168.1.50:6543/``. | |||
| browser by visiting ``http://192.168.1.50:6543/``. Same holds true if you use | |||
There was a problem hiding this comment.
Minor grammar fix.
The same holds
| @@ -316,12 +317,13 @@ the case, if you use a browser running on the same system as Pyramid, it will | |||
| be able to access the application via ``http://127.0.0.1:6543/`` as well as via | |||
| ``http://192.168.1.50:6543/``. However, *other people* on other computers on | |||
| the same network will also be able to visit your Pyramid application in their | |||
| browser by visiting ``http://192.168.1.50:6543/``. | |||
| browser by visiting ``http://192.168.1.50:6543/``. Same holds true if you use | |||
| ipv6. ``[::]`` means the same as ``0.0.0.0`` but for ipv6 protocol. | |||
There was a problem hiding this comment.
More minor grammar fixes.
IPv6. [::] means the same as 0.0.0.0, but for IPv6.
| 127.0.0.1``), on port number 6543 (``port = 6543``). The server code itself | ||
| egg:waitress#main``), and it will listen on all interfaces (``listen = | ||
| 127.0.0.1:6543 [::1]:6543``, means that it will listen on ipv4 and ipv6), | ||
| on port number 6543. The server code itself |
There was a problem hiding this comment.
Minor grammar fixes. Also you no longer need to hard wrap paragraphs.
and it will listen on all interfaces on port 6543 for both IPv4 and IPv6 (listen = 127.0.0.1:6543 [::1]:6543).
|
This is great. I'm leaving this open for now as a reminder, but feel free to help if you want it merged quicker!
|
|
Sphinx pinned to docutils 0.11 in sphinx-doc/sphinx#3217 to resolve sphinx-doc/sphinx#3212 |
|
I went ahead and updated the cookiecutters and triggered a new build on travis which passed. Thank you again for your work! |
|
Sorry, was kinda slammed this week and couldn't update the cookiecutters. It was my pleasure to contribute something. |
Per #2851 I've fixed the files and submitting another pull request.