-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert response callbacks into a tween #2762
convert response callbacks into a tween #2762
Conversation
6a4d411
to
b97e552
Compare
LGTM |
b97e552
to
99eb168
Compare
I'm working on docs for this now. |
There's another issue with this feature that I just noticed. The default for |
99eb168
to
5a7d974
Compare
Updated the docs but I'm worried about the subreqest situation. It feels like a fairly large incompatibility. I argued when the feature was introduced to keep |
I'll review docs when the implementation is finalized. Please ping me at that time, and I'll dive in. |
bf6087b
to
034a8dd
Compare
034a8dd
to
1585f78
Compare
There is a backward incompatibility here in how tweens are defined. This is consistent with the new view deriver API but may present some frustration for anyone currently defining a tween **under** the EXCVIEW as all tweens now default to **over** the EXCVIEW. This incompatibility is not strictly required to implement this feature, but if we don't then: 1) Tween ordering is almost completely dependent on the user's environment and sorting behavior. If they add another tween then the addon tween (if left unspecified) may be shifted to a bad place. 2) Another incompatibility may surface in which a user's tween would show up OVER the response callbacks tween, which would lead to inconsistent behavior versus the previous pipeline where callbacks were always executed after tweens. This patch shifts tweens to be more fully specified which should be generally considered a good thing. Side note, the response callbacks and excview tweens are defined with fallbacks incase one of them is overridden or unavailable for some reason by using a list of dependencies. We should apply this pattern to the view derivers as well to make them easier to override.
1585f78
to
ef2ece1
Compare
I'm going to close this and port over only the changes from config.add_tween that explicitly add tweens OVER excview unless otherwise specified. |
There is a backward incompatibility here in how tweens are defined. This
is consistent with the new view deriver API but may present some
frustration for anyone currently defining a tween under the EXCVIEW
as all tweens now default to over the EXCVIEW.
This incompatibility is not strictly required to implement this feature,
but if we don't then:
Tween ordering is almost completely dependent on the user's
environment and sorting behavior. If they add another tween then the
addon tween (if left unspecified) may be shifted to a bad place.
This is an issue unrelated to this feature... just a lingering issue with
tweens.
Another incompatibility may surface in which a user's tween would
show up OVER the response callbacks tween, which would lead to
inconsistent behavior versus the previous pipeline where callbacks
were always executed after tweens.
This patch shifts tweens to be more fully specified which should be
generally considered a good thing.
Side note, the response callbacks and excview tweens are defined
with fallbacks incase one of them is overridden or unavailable for some
reason by using a list of dependencies. We should apply this pattern to
the view derivers as well to make them easier to override.
Closes #2622.