-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move response callbacks to a tween #2622
Comments
@mcdonc what is the status of this after pycon sprints? |
@mcdonc is there any partial work on this from pycon that you could push? Otherwise I'm going to start working on this from scratch, but would much prefer to continue anything you may have already begun. |
Okay, I'm going to start working on this myself. |
#1336 covers some rants about why this may be a bad idea. At the end of the day it boils down to the |
@mmerickel I believe this may be closed based upon comments here: |
pyramid.tweens.response_callbacks
.config.add_tween
to, by default, always add tweens withunder='response callbacks', over=EXCVIEW
.over='MAIN'
is defined. This is similar to howconfig.add_view_deriver
works with its defaults.add_tween(under=EXCVIEW)
then they should update their code to doadd_tween(under=EXCVIEW, over=MAIN)
.This work will help the TM wrap the response callbacks in #2606.
The text was updated successfully, but these errors were encountered: