Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Option raising AttributeError for str and min_length or max_length (issue #1526) #1527

Merged
merged 9 commits into from
Jul 26, 2022
Merged

Fix Option raising AttributeError for str and min_length or max_length (issue #1526) #1527

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16403b1
Fix #1385
yoggys May 25, 2022
5431af4
Merge branch 'Pycord-Development:master' into master
yoggys May 27, 2022
6e88171
key type fix (int => str)
yoggys May 27, 2022
bfa3a78
Merge branch 'master' of https://github.com/yoggys/pycord
yoggys May 27, 2022
3a96aeb
remove space
yoggys May 27, 2022
949ce3b
Merge branch 'Pycord-Development:master' into master
yoggys May 29, 2022
739aab8
Merge branch 'Pycord-Development:master' into master
yoggys Jun 1, 2022
0124c2a
Merge branch 'Pycord-Development:master' into master
yoggys Jul 26, 2022
0b52488
fix issue discord.commands.Option while str and min/max_length were set
yoggys Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions discord/commands/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,11 +239,11 @@ def __init__(self, input_type: InputType = str, /, description: Optional[str] =
self.min_length: Optional[int] = kwargs.pop("min_length", None)
self.max_length: Optional[int] = kwargs.pop("max_length", None)

if (input_type != SlashCommandOptionType.integer and input_type != SlashCommandOptionType.number
if (self.input_type != SlashCommandOptionType.integer and self.input_type != SlashCommandOptionType.number
and (self.min_value or self.max_value)):
raise AttributeError("Option does not take min_value or max_value if not of type "
"SlashCommandOptionType.integer or SlashCommandOptionType.number")
if input_type != SlashCommandOptionType.string and (self.min_length or self.max_length):
if self.input_type != SlashCommandOptionType.string and (self.min_length or self.max_length):
raise AttributeError('Option does not take min_length or max_length if not of type str')

if self.min_value is not None and not isinstance(self.min_value, minmax_types):
Expand Down