Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Option raising AttributeError for str and min_length or max_length (issue #1526) #1527

Merged
merged 9 commits into from
Jul 26, 2022

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented Jul 26, 2022

Summary

It fixes issue #1526

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Lulalaby Lulalaby enabled auto-merge (squash) July 26, 2022 16:28
@Lulalaby Lulalaby requested a review from Dorukyum July 26, 2022 16:29
@Dorukyum Dorukyum disabled auto-merge July 26, 2022 17:48
@Dorukyum
Copy link
Member

This was tested with other input types too, right?

@yoggys
Copy link
Contributor Author

yoggys commented Jul 26, 2022

This was tested with other input types too, right?

image
Yes, I added a command with various types in order to verify that it was ok earlier - the bug came out on one of my bigger bots when the commands broke during a library update

@Dorukyum Dorukyum enabled auto-merge (squash) July 26, 2022 17:59
@Dorukyum Dorukyum merged commit ff92eb6 into Pycord-Development:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants