Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement PyDictMethods #3531

Closed
wants to merge 1 commit into from
Closed

implement PyDictMethods #3531

wants to merge 1 commit into from

Conversation

davidhewitt
Copy link
Member

As part of #3382, this implements the PyDictMethods trait as pub(crate) and re-implements the existing PyDict API on top of it.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Oct 20, 2023
@davidhewitt
Copy link
Member Author

Ah CI failure on PyPy cfg is unfortunate, can clean that up (and a better API) with #3532.

@davidhewitt davidhewitt mentioned this pull request Oct 20, 2023
Closed
@davidhewitt davidhewitt mentioned this pull request Oct 21, 2023
Closed
@davidhewitt davidhewitt mentioned this pull request Nov 27, 2023
Merged
@adamreichold
Copy link
Member

Is still ready to be reviewed or does it need a rebase after #3651 lands?

@davidhewitt
Copy link
Member Author

I'll try to rebase this and also the tuple PR soon 👍

@davidhewitt davidhewitt marked this pull request as draft December 19, 2023 08:02
@davidhewitt
Copy link
Member Author

Superseded by #3675

@davidhewitt davidhewitt mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @adamreichold