Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Bound and Borrowed types public API #3686

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Conversation

davidhewitt
Copy link
Member

This completes renaming of our temporary names Py2 and Py2Borrowed to Bound and Borrowed, and adds these plus the methods traits to the public API (and the prelude).

src/instance.rs Outdated Show resolved Hide resolved
src/types/boolobject.rs Show resolved Hide resolved
src/err/mod.rs Outdated Show resolved Hide resolved
src/types/list.rs Outdated Show resolved Hide resolved
src/types/dict.rs Outdated Show resolved Hide resolved
@davidhewitt davidhewitt force-pushed the bound branch 3 times, most recently from db3b345 to f2083fb Compare December 21, 2023 13:03
@adamreichold
Copy link
Member

downcast_into_unchecked is now public yet missing a # Safety section.

@davidhewitt
Copy link
Member Author

Added, sorry for the slight delay, had a few bits and pieces going on this afternoon.

@adamreichold adamreichold added this pull request to the merge queue Dec 21, 2023
Copy link

codspeed-hq bot commented Dec 21, 2023

CodSpeed Performance Report

Merging #3686 will improve performances by 22.03%

Comparing davidhewitt:bound (4ac6a6b) with main (2788f4a)

Summary

⚡ 1 improvements
✅ 77 untouched benchmarks

Benchmarks breakdown

Benchmark main davidhewitt:bound Change
not_a_list_via_downcast 153.9 ns 126.1 ns +22.03%

Merged via the queue into PyO3:main with commit a115877 Dec 21, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants