Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Emscripten/Pyodide CI #983

Merged
merged 10 commits into from
Jun 25, 2022
Merged

Conversation

hoodmane
Copy link
Contributor

Since we released new Pyodide alpha, we can clean up the CI job a lot.

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for maturin-guide canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d2ad2c6
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/62b65171fd5412000834c442

@hoodmane
Copy link
Contributor Author

On my local build I get:

💥 maturin failed
  Caused by: Invalid PYO3_CONFIG_FILE
  Caused by: missing value for ext_suffix

but if I put ext_suffix into the PYO3_CONFIG_FILE it says it shouldn't be there. @messense @davidhewitt?

@messense
Copy link
Member

messense commented Jun 25, 2022

but if I put ext_suffix into the PYO3_CONFIG_FILE it says it shouldn't be there

#897 (comment)

https://github.com/PyO3/pyo3/blob/3fd0c0e1421c71b0e5755427eaaa886cc67cd9c1/pyo3-build-config/src/impl_.rs#L436

This is a bug, I guess we can strip maturin specific config keys before passing to pyo3.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense messense merged commit 723c9e3 into PyO3:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants