Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PYO3_CONFIG_FILE #897

Closed
messense opened this issue May 4, 2022 · 1 comment · Fixed by #899
Closed

Add support for PYO3_CONFIG_FILE #897

messense opened this issue May 4, 2022 · 1 comment · Fixed by #899
Labels
bindings/pyo3 pyo3 bindings

Comments

@messense
Copy link
Member

messense commented May 4, 2022

Should there also be a check for PYO3_CONFIG_FILE env var, and just skip all this if so?

Originally posted by @davidhewitt in #896 (comment)
@messense messense added the bindings/pyo3 pyo3 bindings label May 4, 2022
@messense
Copy link
Member Author

messense commented May 5, 2022

Just noticed that maturin needs more fields, namely abiflags, ext_suffix and abi_tag, they are not defined in PYO3_CONFIG_FILE.

@messense messense mentioned this issue May 5, 2022
Merged
@messense messense mentioned this issue Jun 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bindings/pyo3 pyo3 bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for PYO3_CONFIG_FILE messense/maturin
1 participant
@messense