Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PYO3_CONFIG_FILE #899

Merged
merged 4 commits into from
May 7, 2022
Merged

Add support for PYO3_CONFIG_FILE #899

merged 4 commits into from
May 7, 2022

Conversation

messense
Copy link
Member

@messense messense commented May 5, 2022 •
edited
Loading

Closes #897

@netlify
Copy link

netlify bot commented May 5, 2022 •
edited
Loading

✅ Deploy Preview for maturin-guide canceled.

Name Link
🔨 Latest commit a0cb06f
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6273b5728cd6b30008db5d32

@messense messense marked this pull request as ready for review May 5, 2022 08:10
@messense messense requested a review from davidhewitt May 5, 2022 08:22
@messense messense force-pushed the pyo3-config-file branch from 164f888 to 847fe62 Compare May 5, 2022 11:13
@messense messense force-pushed the pyo3-config-file branch from 5446ab1 to a0cb06f Compare May 5, 2022 11:30
@messense messense merged commit e8a6671 into PyO3:main May 7, 2022
@messense messense deleted the pyo3-config-file branch May 7, 2022 03:30
@davidhewitt
Copy link
Member

Thanks for implementing this! Sorry I didn't get around to reviewing in time. LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt Awaiting requested review from davidhewitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for PYO3_CONFIG_FILE
2 participants
@messense @davidhewitt