Fix build_sdist return value for PEP 517
#336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
fix-build-sdist
branch
from
7a16a43 to
58368e3
Compare
Closed
|
@konstin just wanted to check you agree this implementation is sensible. If you are happy with it, I will also update the README as tox support should work with next version of maturin 😄 |
|
Thanks for pointing this out, I've fixed this on the rust side in 7808bbf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to [PEP 517] the
build_sdisthook should return just thebasenameof the output archive.https://www.python.org/dev/peps/pep-0517/#build-sdist