Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tox with PEP 517 #176

Closed
konstin opened this issue Aug 11, 2019 · 8 comments
Closed

Tox with PEP 517 #176

konstin opened this issue Aug 11, 2019 · 8 comments
Labels
bug Something isn't working

Comments

@konstin
Copy link
Member

konstin commented Aug 11, 2019

Tox fails when using pyo3-pack through PEP 517 due to tox-dev/tox#1344.
@konstin konstin added bug Something isn't working blocked Something is blocking this labels Aug 11, 2019
@konstin konstin mentioned this issue Aug 11, 2019
Closed
@KeironO
Copy link

KeironO commented Aug 12, 2019

Would it be possible to get an estimate of how long it'll take for this to be fixed? If it's not high on your priority list, is there any way in which I can make a workaround for this?

@konstin
Copy link
Member Author

konstin commented Sep 5, 2019

@thedrow I forgot to also rename the pyo3_pack directory which I've fixed in 04206b9. With that commit the old error message should return.

@konstin
Copy link
Member Author

konstin commented Sep 6, 2019

It's already released

@davidhewitt
Copy link
Member

FYI as of tox 3.18.1 the issue should be resolved in tox. From local testing when writing maturing examples for pyo3 I think we need #336 to be merged, and then we should be good to update the readme!

@konstin konstin removed the blocked Something is blocking this label Jul 29, 2020
@konstin
Copy link
Member Author

konstin commented Jul 29, 2020

I've tested an it works now, however testing locally is tedious due to tox-dev/tox#1634. I'll update the examples

@konstin
Copy link
Member Author

konstin commented Jul 29, 2020

@davidhewitt Thank you very much for fixing the original bug in tox!

@konstin konstin closed this as completed Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidhewitt @KeironO @konstin and others