Add support for linking with pyo3 in abi3 debug mode on Windows #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
force-pushed
the
windows-debug-abi3-ext-suffix
branch
from
d8df50a to
40cea0d
Compare
messense
changed the title
messense
force-pushed
the
windows-debug-abi3-ext-suffix
branch
from
40cea0d to
0841694
Compare
|
The code is getting too messy, I'd definitely find time to refactor internals after 1.0 release. bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
1487: Add support for linking with pyo3 in abi3 debug mode on Windows r=messense a=messense Closes #1465 Co-authored-by: messense <[email protected]>
|
Canceled. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 16, 2023
1487: Add support for linking with pyo3 in abi3 debug mode on Windows r=messense a=messense Closes #1465 Co-authored-by: messense <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1465