Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linking with pyo3 in abi3 debug mode on Windows #1465

Closed
messense opened this issue Feb 8, 2023 · 1 comment · Fixed by #1487
Closed

Support linking with pyo3 in abi3 debug mode on Windows #1465

messense opened this issue Feb 8, 2023 · 1 comment · Fixed by #1487
Labels
bindings/pyo3 pyo3 bindings

Comments

@messense
Copy link
Member

messense commented Feb 8, 2023

when testing this, I found that maturin produced abi3 builds using .pyd suffix, even if ext_suffix in PYO3_CONFIG_FILE was set to something else. It looks like these debug builds only import abi as _d.pyd or version-specific as e.g. _d.cp312-win_amd64.pyd. Might need to adjust maturin a little?

Originally posted by @davidhewitt in PyO3/pyo3#2937 (comment)

@messense messense added the bindings/pyo3 pyo3 bindings label Feb 8, 2023
@messense
Copy link
Member Author

abi3 so name is currently hard-coded.

let so_filename = match python_interpreter {
Some(python_interpreter) => python_interpreter.get_library_name(ext_name),
// abi3
None => {
if target.is_unix() {
format!("{ext_name}.abi3.so")
} else {
// Apparently there is no tag for abi3 on windows
format!("{ext_name}.pyd")
}
}
};

@messense messense changed the title Support linking with pyo3 in debug mode on Windows Support linking with pyo3 in abi3 debug mode on Windows Feb 15, 2023
bors bot added a commit that referenced this issue Feb 16, 2023
1487: Add support for linking with pyo3 in abi3 debug mode on Windows r=messense a=messense

Closes #1465 

Co-authored-by: messense <[email protected]>
bors bot added a commit that referenced this issue Feb 16, 2023
1487: Add support for linking with pyo3 in abi3 debug mode on Windows r=messense a=messense

Closes #1465 

Co-authored-by: messense <[email protected]>
@bors bors bot closed this as completed in 83e6b70 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/pyo3 pyo3 bindings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant