Remove support for specifying python package metadata in Cargo.toml
#1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
messense
changed the title
Cargo.tomlCargo.toml
messense
commented
Oct 17, 2022
| #[serde(rename_all = "kebab-case")] | ||
| #[serde(deny_unknown_fields)] |
There was a problem hiding this comment.
Had to remove this to deserialize unknown fields to other and print a warning for it.
| @@ -144,34 +104,22 @@ struct CargoTomlMetadata { | |||
| /// Those fields are the part of the | |||
| /// [python core metadata](https://packaging.python.org/specifications/core-metadata/) | |||
| /// that doesn't have an equivalent in cargo's `[package]` table | |||
| #[derive(Serialize, Deserialize, Debug, Clone, Eq, PartialEq, Default)] | |||
There was a problem hiding this comment.
I don't think we need Eq/PartialEq in maturin, and HashMap<String, toml_edit::easy::Value> prevents deriving them.
messense
added a commit
that referenced
this pull request
Oct 17, 2022
messense
added a commit
that referenced
this pull request
Oct 17, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 20, 2022
https://build.opensuse.org/request/show/1036879 by user mia + dimstar_suse - Update to v0.14.0: * Breaking Change: Remove support for specifying python package metadata in `Cargo.toml` Python package metadata should be specified in the `project` section of `pyproject.toml` instead as PEP 621 specifies. gh#PyO3/maturin#1200 * Initial support for shipping bin targets as wasm32-wasi binaries that are run through wasmtime Note that wasmtime currently only support the five most popular platforms and that wasi binaries have restrictions when interacting with the host. Usage is by setting `--target wasm32-wasi`. gh#PyO3/maturin#1107 * Add support for python first `src` project layout gh#PyO3/maturin#1185 * Add `--src` option to generate src layout for mixed Python/Rust projects gh#PyO3/maturin#1189 * Add Python metadata support for `license-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1047