Build platform independent rust binary wheel through wasi #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
reviewed
Sep 16, 2022
| # TODO: this is taken from https://docs.wasmtime.dev/api/wasmtime/struct.Linker.html#method.get_default | ||
| # is this always correct? | ||
| start = linking1.exports(store).get("") or linking1.exports(store)["_start"] | ||
| start(store) |
There was a problem hiding this comment.
I remember that wasmtime execution is sandboxed, so you might need to give access to file systems explicitly somehow?
There was a problem hiding this comment.
i think so, let's see if i get a response in bytecodealliance/wasmtime-py#94 and otherwise i'll have to collect some real world use cases compatible with wasm
messense
reviewed
Sep 16, 2022
messense
reviewed
Sep 16, 2022
|
|
|
yet that's the next step |
This comment was marked as outdated.
This comment was marked as outdated.
messense
added
bindings/bin
We build the rust binaries to wasi and put them in a wheel with a wasmtime launcher. The resulting wheels are platform independent (py3-none-any) and run on all wasmtime platforms. Those are currently less than maturin natively, but you still only have to build one wheel and i hope for some nice things in the future (isolation capabilities, wasm runtimes on less-supported platforms)
konstin
changed the title
|
ready to merge from my end |
messense
reviewed
Oct 9, 2022
messense
approved these changes
Oct 9, 2022
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 20, 2022
https://build.opensuse.org/request/show/1036879 by user mia + dimstar_suse - Update to v0.14.0: * Breaking Change: Remove support for specifying python package metadata in `Cargo.toml` Python package metadata should be specified in the `project` section of `pyproject.toml` instead as PEP 621 specifies. gh#PyO3/maturin#1200 * Initial support for shipping bin targets as wasm32-wasi binaries that are run through wasmtime Note that wasmtime currently only support the five most popular platforms and that wasi binaries have restrictions when interacting with the host. Usage is by setting `--target wasm32-wasi`. gh#PyO3/maturin#1107 * Add support for python first `src` project layout gh#PyO3/maturin#1185 * Add `--src` option to generate src layout for mixed Python/Rust projects gh#PyO3/maturin#1189 * Add Python metadata support for `license-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this idea that besides having to build a wheel for each platform and then still there are platforms without manylinux supports, we could have a single wasm wheel as a generic fallback. Currently more theoretical since wasmtime supports less platforms than manylinux. Also we could have isolation and such in the future.
We build the rust binaries to wasi and put them in a wheel with a wasmtime launcher. The resulting wheels are platform independent (py3-none-any) and run on all wasmtime platforms.
TODO: