-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pypy support #105
pypy support #105
Conversation
I see this as working fine with pypy3 v7.1 and python3.7. |
FYI I've added two pypy sysconfigs as reference |
@konstin both PyPy3.5 6.0.0, and PyPy3.6 7.0.0/7.1.0 aren't fully working. I'd suggest adding the PyPy3.5 7.0.0 that is currently on the website |
FWIW at least cargo check did work for me with 3.5 6.0 and 3.6 7.0 did work with the patch I posted on the other thread (I basically disabled a few symbols; I haven't check which of them would actually be supported, but it's easy to add a symbols when the base support is working). But I agree that we should settle on pypy >= 7.0 and I've updated the sysconfig. |
Using |
Ok, regarding EXT_SUFFIX and SOABI, the existing logic is kept for non-pypy builds. I can't test pypy on Windows or mess with AppVeyor right now, though. |
src/python_interpreter.rs
Outdated
} | ||
} | ||
|
||
/// Generates the correct suffix for shared libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-add that doc comment. Probably it's the best to move the cpython logic to its own function and re-add the comment there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I readded it and some on pypy here.
I've uploaded a sysconfig for windows, but unfortunately I don't have any reference on how a native extension for pypy should look like on windows. I'm however fine to merge this if we document pypy support as linux only and make a separate issue for windows/mac testing |
Building on your work, I've created a I don't know what's the best way to proceed with this pull request; Do you want to rebase onto master and cherry-pick my commit or should I open another pull request? I'm fine with merging |
Go ahead with pypy-ux. |
No description provided.