Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full PyPy support #115

Closed
11 tasks done
konstin opened this issue Apr 17, 2019 · 4 comments
Closed
11 tasks done

Full PyPy support #115

konstin opened this issue Apr 17, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@konstin
Copy link
Member

konstin commented Apr 17, 2019

pyo3-pack gets basic pypy support from #105, while some things are still missing.

  • Add some automated testing, ideally on ci as pyo3 does.
  • Figure out the best way to deal with manylinux.
  • Add windows support
    • Find a reference how a native pypy wheel on windows should look like: python_Levenshtein-0.10.2-pp38-pypy38_pp73-win_amd64.whl contains Levenshtein.pypy38-pp73-win_amd64.pyd: https://paste.rs/ZAJ
  • Test on mac (done by @messense, it works)
  • Skip pypy wheels when uploading
  • Autodetect pypy binaries, but only for pyo3
  • Look for a better way than using SOABI to determine the native extensions filename since that value isn't define on windows for both cpython and pypy. SOABI is defined on windows for at least pypy 3.7 and later.
  • Allow building for non-abi3 pypy wheels when the abi3 feature is enabled #460
@konstin konstin added the enhancement New feature or request label Jul 9, 2019
milesgranger added a commit to milesgranger/cramjam that referenced this issue Feb 18, 2021
milesgranger added a commit to milesgranger/cramjam that referenced this issue Feb 18, 2021
Needs to run pypy_patch.py after builds until PyO3/maturin#312 is closed
Cannot support Windows PyPy until PyO3/maturin#115 is closed
@mattip
Copy link

mattip commented Sep 1, 2021

I got here from a failing build of pywinpty when rebuilding for PyPy3.7 and windows. The failure is ERROR: pywinpty-1.1.3-pp3pp73-pypy3_pp73-win_amd64.whl is not a supported wheel on this platform. (link may dissapear in a week or so). The project uses maturin build --release -i pypy3.7.exe.

Bottom line: The wheel name should end with -pp37-pypy37_pp73-win_amd64.whl not -pp3pp73-pypy3_pp73-win_amd64.whl. Any ideas where the extra pp3 at the beninning is coming from?

Some additional comments:

  • Add some automated testing, ideally on ci as pyo3 does:
    github actions setup-pythonv2 supports pypy
  • Look for a better way than using SOABI to determine the native extensions filename since that value isn't define on windows for both cpython and pypy:
    I think sysconfig.get_config_var('SOABI') is the canonical way to do this. What versions of python do not support it? You could get some inspriation from the pypa/wheel source code

@messense
Copy link
Member

messense commented Sep 1, 2021

Bottom line: The wheel name should end with -pp37-pypy37_pp73-win_amd64.whl not -pp3pp73-pypy3_pp73-win_amd64.whl. Any ideas where the extra pp3 at the beninning is coming from?

"pp{major}{minor}-pypy{major}{minor}_{abi_tag}-{platform}",

It comes from here.

@mattip
Copy link

mattip commented Sep 1, 2021

Got it thanks: that was changed for version 0.11.3, and the feedstock is pinning to <=0.9.1

@messense
Copy link
Member

All done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants