-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maturin build & upload fails due to "malformed summary" #1998
Comments
Sorry but you also need to share your binding code, at least |
Hi sorry for the slow reply, after making some assumptions as to what |
I'm also running into this issue, but it seems to me that the correct key in pyproject.toml is in fact Here is a log from such an upload And the corresponding pyproject file: |
I'm also facing this issue, and it's also my understanding that E.x. from my project: https://github.com/wheretrue/biobear/actions/runs/8368683483/job/22915105523 |
Decided to reopen as there are others facing the same issues |
Our releases at Delta-rs are also failing suddenly: https://github.com/delta-io/delta-rs/actions/runs/8365191045/job/22918909428#step:3:1 |
@ion-elgreco Can you unpack the wheel that fails the upload and paste it's metadata content here? |
@messense not sure how to download the wheel from the failed action, if you have some pointers? But from a locally built release with maturin, the description looks fine: |
That https://packaging.python.org/en/latest/specifications/core-metadata/#core-metadata-summary
|
@ion-elgreco Can you run |
That's the confusing part, nothing changed on our side in the description between 0.16.1 and 0.16.2. Both were built with maturin 1.5. @messense I did yesterday, twine check passed on that wheel |
Maybe it's related to this pypi change: pypi/warehouse#15631 |
Looks to be re raised from there: https://github.com/pypi/warehouse/pull/15631/files#diff-631b24361675bcbc0f1aa65df703ce99f10d505f6d95a067c7e1f33fd961ee86R327 So for some reason summaries are not parsed anymore? |
Here is a metadata file from one of the wheels that showed this error. I could upload the file using twine without issues.
|
Can anyone try #2002? Clone this repo and switch to that branch and run |
@messense I am at work atm, I can trigger a new CI though if you already push a release, since it will automatically pick up the new version; p |
I'll push a new release after work. For now, if anyone is blocked by this, switch to twine for upload. |
@messense Thankss! |
@messense our releases are working again, thanks for the quick fix <3 |
### What - Resolves: #5729 Pypi changed something in their parsing library that required an update to maturin. See: PyO3/maturin#1998 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5730/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5730/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5730/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5730) - [Docs preview](https://rerun.io/preview/7a22dce6927e560a74b212cee636ee75a250826a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/7a22dce6927e560a74b212cee636ee75a250826a/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Bug Description
I am currently facing an issue whereby after building the wheel distribution file,
maturin upload
fails with the following error,I am also building through
docker run
After using
unzip
on the wheel file, I find that the outputted METADATA is using Metadata-Version 2.1, not too sure if this would be relevant.Your maturin version (
maturin --version
)1.4.0
Your Python version (
python -V
)n/a
Your pip version (
pip -V
)n/a
What bindings you're using
pyo3
Does
cargo build
work?If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash
/
)?Steps to Reproduce
./build.sh
Output:
maturin upload mydistribution-1.3.7b1-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Output:
The text was updated successfully, but these errors were encountered: