Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show report published date with fallback to created #657

Merged
merged 6 commits into from
Mar 22, 2022

Conversation

TinHoangVu
Copy link
Contributor

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the Issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Changing the header on projectstatus report to show published date, instead of created date.

How to test

  • 1. Create new report on day x
  • 2. Publish the report on day x+1
  • 3. See the date chaning when published.

Update of documentation

  • Check if user manual requires update
    • No
    • Yes
      • Update user manual

Relevant issues (if applicable)

#654

💔Thank you!

@TinHoangVu TinHoangVu self-assigned this Mar 8, 2022
@TinHoangVu TinHoangVu added the backend Related to backend/apis label Mar 8, 2022
@TinHoangVu TinHoangVu added this to the 1.5.0 milestone Mar 8, 2022
@olemp
Copy link
Collaborator

olemp commented Mar 8, 2022

You should base the branch on dev - not the previous PR branch. Please redo PR.

@olemp olemp closed this Mar 8, 2022
@olemp olemp deleted the feature/654-PublishedDate branch March 8, 2022 10:49
@TinHoangVu TinHoangVu restored the feature/654-PublishedDate branch March 22, 2022 08:10
@TinHoangVu TinHoangVu reopened this Mar 22, 2022
@TinHoangVu TinHoangVu closed this Mar 22, 2022
@TinHoangVu TinHoangVu deleted the feature/654-PublishedDate branch March 22, 2022 08:39
@TinHoangVu TinHoangVu restored the feature/654-PublishedDate branch March 22, 2022 08:42
@TinHoangVu TinHoangVu reopened this Mar 22, 2022
@TinHoangVu TinHoangVu force-pushed the feature/654-PublishedDate branch from 83fc595 to bd69c33 Compare March 22, 2022 08:46
@TinHoangVu
Copy link
Contributor Author

PR is up to date

@TinHoangVu TinHoangVu changed the title Feature/654 published date Added GtLastReportdate to show published date instead of created date Mar 22, 2022
@olemp
Copy link
Collaborator

olemp commented Mar 22, 2022

We already have publishedDate @TinHoangVu

@olemp olemp closed this Mar 22, 2022
@olemp olemp deleted the feature/654-PublishedDate branch March 22, 2022 08:57
@tarjeieo tarjeieo restored the feature/654-PublishedDate branch March 22, 2022 09:13
@tarjeieo tarjeieo reopened this Mar 22, 2022
@tarjeieo
Copy link
Member

@TinHoangVu can you remove the new property, but use published date in the react component?

olemp added 2 commits March 22, 2022 10:16
Show report published date with fallback to created.
@olemp olemp changed the title Added GtLastReportdate to show published date instead of created date Show report published date with fallback to created Mar 22, 2022
@olemp olemp merged commit 3ce3290 into dev Mar 22, 2022
@olemp olemp deleted the feature/654-PublishedDate branch March 22, 2022 09:17
@Remi749
Copy link
Collaborator

Remi749 commented Mar 24, 2022

Ser det henger igjen noe her fra det som ble fjernet på StatuReport typen

Property 'publishedDate' does not exist on type 'StatusReport'

image

Servet bare latest på dev.

@olemp
Copy link
Collaborator

olemp commented Mar 24, 2022

Ser det henger igjen noe her fra det som ble fjernet på StatuReport typen

Property 'publishedDate' does not exist on type 'StatusReport'

image

Servet bare latest på dev.

Try npm install to get latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend/apis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants