Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/654 published date #656

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Feature/654 published date #656

merged 4 commits into from
Mar 7, 2022

Conversation

TinHoangVu
Copy link
Contributor

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the Issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Added gtLastReportDate to statusreport model to show published date and time for published statusreport.
@tarjeieo You need to update the npm package pp365-shared so that we can use the gtLastReportDate field later.
When this is done, i will add the gtLastReportdate field to show published date.

Relevant issues (if applicable)

#654

@TinHoangVu TinHoangVu added the backend Related to backend/apis label Mar 7, 2022
@TinHoangVu TinHoangVu added this to the 1.5.0 milestone Mar 7, 2022
@TinHoangVu TinHoangVu requested a review from tarjeieo March 7, 2022 14:39
@TinHoangVu TinHoangVu requested review from olemp and okms as code owners March 7, 2022 14:39
@TinHoangVu TinHoangVu self-assigned this Mar 7, 2022
@@ -20,6 +22,8 @@ export class StatusReport {
constructor(private _item: TypedHash<any>, private _publishedString?: string) {
this.id = _item.Id
this.created = new Date(_item.Created)
this.modified = new Date(_item.Modified)
this.gtLastReportDate = new Date(_item.GtLastReportDate)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke ta med feltprefiks i navnet. publishedDate, ikke gtLastReportDate.

@olemp olemp merged commit 99df07a into dev Mar 7, 2022
@olemp olemp deleted the feature/654-PublishedDate branch March 7, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend/apis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants