Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create search bar component #216

Merged
merged 19 commits into from
Jul 12, 2022
Merged

Create search bar component #216

merged 19 commits into from
Jul 12, 2022

Conversation

Noamili
Copy link
Contributor

@Noamili Noamili commented Jun 18, 2022 •
edited
Loading

close #197
TODO Change target branch to staging

Default value:
Screen Shot 2022-07-03 at 20 47 12

When searching:
Screen Shot 2022-07-03 at 20 47 26
@MichalPorag updated design

@netlify
Copy link

netlify bot commented Jun 18, 2022 •
edited
Loading

✅ Deploy Preview for agitated-hoover-61371e ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 53ff210
🔍 Latest deploy log https://app.netlify.com/sites/agitated-hoover-61371e/deploys/62ca938ee6b7f100082e6405
😎 Deploy Preview https://deploy-preview-216--agitated-hoover-61371e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Preview on netlify: https://deploy-preview-216--pull-request.netlify.app/

@Noamili Noamili changed the base branch from master to staging June 28, 2022 16:07
OmriBarZik and others added 5 commits July 2, 2022 10:06
@OmriBarZik
chore: remove idea folder (Pull-Request-Community#236)
554b82d
@shir22
updating readme: custom image (Pull-Request-Community#239)
5e9ea19
@lirantal
test: add e2e infra with playwright and a sample test (Pull-Request-C…
365afa6 
…ommunity#235)

* test: add e2e infra with playwright and a sample test

* test: add github action for e2e test

* test: add config for framework spin-up
@Yedidyar
Yedidyar/issue167 (Pull-Request-Community#240)
b452576 
* feat: add Yedidya Rashi profile (Pull-Request-Community#220)

* fix: randomShuffle isn't working correctly  (Pull-Request-Community#167)
@Yedidyar
fix(Description): wrap descriptionHeight with useEffect (Pull-Request…
d7e85d9 
…-Community#243)

see more about the issue:
https://stackoverflow.com/questions/62336340/cannot-update-a-component-while-rendering-a-different-component-warning
MichalPorag
MichalPorag requested changes Jul 2, 2022
View reviewed changes
Copy link
Collaborator

@MichalPorag MichalPorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just a few comments :)

components/searchBar/SearchBar.tsx Show resolved Hide resolved
components/searchBar/SearchBar.module.scss Outdated Show resolved Hide resolved
components/searchBar/SearchBar.module.scss Outdated Show resolved Hide resolved
components/searchBar/SearchBar.module.scss Show resolved Hide resolved
components/searchBar/SearchBar.module.scss Outdated Show resolved Hide resolved
@Noamili Noamili requested a review from MichalPorag July 3, 2022 17:48
@Noamili Noamili force-pushed the search-bar-component branch from 333a92b to 98b4e33 Compare July 3, 2022 18:13
@Noamili Noamili force-pushed the search-bar-component branch from ace3ce8 to e2856bd Compare July 8, 2022 12:42
@Noamili Noamili force-pushed the search-bar-component branch from 6f6ea1d to 8780511 Compare July 10, 2022 08:51
@Noamili Noamili force-pushed the search-bar-component branch from 8780511 to ab423a5 Compare July 10, 2022 08:51
@MichalPorag MichalPorag merged commit 2afd7ff into Pull-Request-Community:staging Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPorag MichalPorag MichalPorag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Projects screen] Crate a search bar component
8 participants
@Noamili @MichalPorag @Yedidyar @OmriBarZik @shir22 @lirantal @InbarDanieli @noamilsh