Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Description): wrap descriptionHeight with useEffect #243

Conversation

Yedidyar
Copy link
Contributor

@Yedidyar Yedidyar commented Jul 1, 2022

@netlify
Copy link

netlify bot commented Jul 1, 2022

Deploy Preview for agitated-hoover-61371e ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7fca796
🔍 Latest deploy log https://app.netlify.com/sites/agitated-hoover-61371e/deploys/62beab4c756f030008c84922
😎 Deploy Preview https://deploy-preview-243--agitated-hoover-61371e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Preview on netlify: https://deploy-preview-243--pull-request.netlify.app/

Copy link
Collaborator

@MichalPorag MichalPorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you :)

@MichalPorag MichalPorag merged commit d7e85d9 into Pull-Request-Community:master Jul 2, 2022
MichalPorag pushed a commit that referenced this pull request Jul 8, 2022
* feat: add Yedidya Rashi profile (#220)

* chore: remove idea folder (#236)

* updating readme: custom image (#239)

* test: add e2e infra with playwright and a sample test (#235)

* test: add e2e infra with playwright and a sample test

* test: add github action for e2e test

* test: add config for framework spin-up

* Yedidyar/issue167 (#240)

* feat: add Yedidya Rashi profile (#220)

* fix: randomShuffle isn't working correctly  (#167)

* fix(Description): wrap descriptionHeight with useEffect (#243)

see more about the issue:
https://stackoverflow.com/questions/62336340/cannot-update-a-component-while-rendering-a-different-component-warning

* There is no background for the role of Former admin label
Fixes #241

* Test (#238)

* inital commit

* revert change

Co-authored-by: noa <[email protected]>

Co-authored-by: yedidya rashi <[email protected]>
Co-authored-by: Omri Bar-Zik <[email protected]>
Co-authored-by: shir22 <[email protected]>
Co-authored-by: Liran Tal <[email protected]>
Co-authored-by: Inbar Danieli <[email protected]>
Co-authored-by: noa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants