Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVP with no team #2834

Closed
wants to merge 24 commits into from
Closed

PVP with no team #2834

wants to merge 24 commits into from

Conversation

ATFGK
Copy link
Contributor

@ATFGK ATFGK commented Nov 12, 2022

resolved #2617

An additional option pvpwithnoteam is added at PvPMode to enable PVP with no team

@drunderscore
Copy link
Contributor

It feels a bit weird to specify team properties in a configuration option named PvPMode... how about creating a new configuration option (such as TeamMode), with similar options to PvPMode, where:

  • normal, which is the default, and does nothing
  • disabled, which prevents team switching
  • A team name, such as red or blue, which forces players onto that team

That way all the existing options of PvPMode can be used alongside TeamMode in multiple configurations.

@ATFGK
Copy link
Contributor Author

ATFGK commented Nov 12, 2022

It feels a bit weird to specify team properties in a configuration option named ... how about creating a new configuration option (such as ), with similar options to , where:PvPMode``TeamMode``PvPMode

  • normal, which is the default, and does nothing
  • disabled, which prevents team switching
  • A team name, such as or , which forces players onto that teamred``blue

That way all the existing options of can be used alongside in multiple configurations.PvPMode``TeamMode

This idea seems good, but it doesn't seem to work because the same team will lose its PVP

@ATFGK ATFGK changed the title Pvp with no team PVP with no team Nov 12, 2022
@sgkoishi
Copy link
Member

Would it be better to use permission to restrict team switch and pvp?

@ATFGK
Copy link
Contributor Author

ATFGK commented Nov 13, 2022

Would it be better to use permission to restrict team switch and pvp?

Maybe so.

@sgkoishi
Copy link
Member

It's usually suggested to use another branch to merge unrelated changes since this branch is connected to a PR.

@ATFGK ATFGK mentioned this pull request Nov 27, 2022
@hakusaro
Copy link
Member

@ATFGK can you clean this PR up or at least point to the exact commit(s) you want merged so that we can potentially just cherry-pick the changes? Each PR tree should be an independent set of changes. This is really confusing and not likely something we can merge without significant cleanup of this branch.

@ATFGK
Copy link
Contributor Author

ATFGK commented Nov 28, 2022

@ATFGK can you clean this PR up or at least point to the exact commit(s) you want merged so that we can potentially just cherry-pick the changes? Each PR tree should be an independent set of changes. This is really confusing and not likely something we can merge without significant cleanup of this branch.

I will resend it.....

@ATFGK ATFGK closed this Nov 28, 2022
@ATFGK ATFGK deleted the PVPWithNoTeam branch November 28, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force players to not be able to switch to a team.
4 participants