upgrade latest puppeteer (includes M1 Mac support) #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
related to #675 + #611 / #630
(my guess is due to one of the issues below, the build github action will likely time out and fail)Summary of Changes
Was testing out upgrading puppeteer in the #611 branch but was seeing an issue where I could build index.html but anything more than that, like just index.html + pages/about would hang and never complete all the pre-rendering. 😕
Found a solution!
(I was able to get the issue in #675 somewhat resolved by seemingly attributing it to
<app-banner>
but my results are still mostly inconclusive)So decided to test it against master and still the same issue with not being able to build more than a few pages.
So aside from that, things work (obviously no menu if no pages 🤷♂️ )
Thoughts / TODOs
browser
instance, we are opening apage
/ tab for every page in the app at once. Perhaps this is overwhelming the newer version of chromium?