Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable throttling of max number of pages that can be prerendered at once #720

Open
1 of 5 tasks
thescientist13 opened this issue Sep 10, 2021 · 0 comments
Open
1 of 5 tasks
Labels
CLI documentation Greenwood specific docs feature New feature or request
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As noted in #699 , one thing we'e not doing is capping the max number of (in this case) browser tabs that are being opened at once by puppeteer. For a small site, opening 20 - 30 pages / tabs may not be an issue, but should Greenwood really open 100 browser tabs though if the site has 100 pages? i feel like at a decent amount of scale, this could break down pretty quickly. 🤔

Details

The thought process being that we can limit the number of max pages being being pre-rendered at once, be it puppeteer, or some other renderer (#709 ) can manage the firehose at their discretion, with maybe a default being detected based on system resources, or just a fixed number?

This should also be exposed through greenwood.config.js.

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) documentation Greenwood specific docs CLI labels Sep 10, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Sep 10, 2021
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI documentation Greenwood specific docs feature New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant