Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 676 support query params with serve dev proxy #677

Merged

Conversation

thescientist13
Copy link
Member

Related Issue

resolves #676

Summary of Changes

  1. Pass full URL to prodServer when proxying
  2. Added test cases for develop and serve commands (assumption being if the call was just /api/albums/ the response would be > 1)

@thescientist13 thescientist13 added bug Something isn't working CLI labels Jul 30, 2021
@thescientist13 thescientist13 changed the title Bug/issue 676 support query params serve dev proxy Bug/issue 676 support query params with serve dev proxy Jul 30, 2021
@thescientist13 thescientist13 merged commit c6c6286 into master Aug 4, 2021
@thescientist13 thescientist13 deleted the bug/issue-676-support-query-params-serve-dev-proxy branch August 4, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devServer proxy query parameters are not respected when running serve command
1 participant