Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devServer proxy query parameters are not respected when running serve command #676

Closed
1 of 5 tasks
thescientist13 opened this issue Jul 30, 2021 · 0 comments · Fixed by #677
Closed
1 of 5 tasks

devServer proxy query parameters are not respected when running serve command #676

thescientist13 opened this issue Jul 30, 2021 · 0 comments · Fixed by #677
Assignees
@thescientist13
Labels
bug Something isn't working CLI v0.15.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As reported in ContributaryCommunity/www.contributary.community#93 if you had an entry in devServer.proxy and ran the yarn command, the proxy would work but it would fail to append query parameters.

Expected

https://www.somehost.com/api/<resource>?param=foo

Actual

https://www.somehost.com/api/<resource>

Details

Somewhat related to #579 it looks like this was overlooked, but! After having merged #670, we should (now or eventually) have the mechanism by which to write a test case for this. 💪
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI v0.15.0
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Bug/issue 676 support query params with serve dev proxy ProjectEvergreen/greenwood
1 participant
@thescientist13