Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/issue 512 default app template merge fixes #513

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Bug/issue 512 default app template merge fixes #513

merged 4 commits into from
Apr 16, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 8, 2021 •
edited
Loading

Related Issue

resolves #512

Summary of Changes

  1. refactored / decoupled getting contents of app and page templates
  2. created a default page template to ensure basic consistency of output content
  3. improved test coverage for <html> and <meta charset> tag
  4. added a test case for specifically testing "bare" page template

TODO

  1. validate correct merging of top level pages as identified here upgrade to 0.10.0 projectevergreen.github.io#36
  2. Would like to refactor <head> tag merging if I can

@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI labels Apr 8, 2021
This was referenced Apr 8, 2021
Merged
Merged
@thescientist13 thescientist13 self-assigned this Apr 10, 2021
@thescientist13 thescientist13 added the question Further information is requested label Apr 10, 2021
@thescientist13 thescientist13 mentioned this pull request Apr 12, 2021
Merged
7 tasks
@thescientist13
Copy link
Member Author

Opened up an issue to track the question / feature around default lang attribute for app.html template.
#558

@thescientist13 thescientist13 added v0.10.1 and removed question Further information is requested labels Apr 16, 2021
@thescientist13 thescientist13 merged commit 8fdcbb1 into master Apr 16, 2021
@thescientist13 thescientist13 deleted the bug/issue-512-default-app-template-merge-fixes branch April 16, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
1 participant
@thescientist13