Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues when merging (empty) page templates with (default) app templates leads to missing head tags in final output #512

Closed
1 of 5 tasks
thescientist13 opened this issue Apr 8, 2021 · 0 comments · Fixed by #513
Closed
1 of 5 tasks

issues when merging (empty) page templates with (default) app templates leads to missing head tags in final output #512

thescientist13 opened this issue Apr 8, 2021 · 0 comments · Fixed by #513
Assignees
@thescientist13
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.10.1
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of working on #511 , I noticed that there were a couple bugs / incorrect assumptions being made in the app <> page template merging logic.

Details

Some examples include:

  1. Merging tags in the <head> assumed there was already an existing <style> / <script> / <link> tag
  2. Default app.html content ("Welcome to the website") was showing up in page output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP v0.10.1
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Bug/issue 512 default app template merge fixes ProjectEvergreen/greenwood
1 participant
@thescientist13