Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 352 menu item chevron alignment #353

Conversation

hutchgrant
Copy link
Member

Related Issue

Resolves #352

Summary of Changes

Adds CSS grid to menu items.

@hutchgrant hutchgrant force-pushed the bug/issue-352-menu-item-chevron-alignment branch from d519ab6 to 069dd50 Compare May 7, 2020 18:28
@hutchgrant hutchgrant changed the base branch from master to bug/issue-350-menu-collapse May 7, 2020 18:45
@hutchgrant
Copy link
Member Author

#350 alone will not work properly without this fix. I am conflicted, if I put these 2 issues in one PR I expect I'll be asked to separate them. However, one won't work without the other.

@thescientist13 thescientist13 merged commit 3f34548 into bug/issue-350-menu-collapse May 8, 2020
@thescientist13 thescientist13 deleted the bug/issue-352-menu-item-chevron-alignment branch May 8, 2020 02:13
@thescientist13 thescientist13 added the website Tasks related to the projects website / documentation label May 8, 2020
thescientist13 added a commit that referenced this pull request May 13, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* fix: add css rule pointer-events

* fix: add css grid (#353)

* fix: remove invalid h2 within inline element

Co-authored-by: hutchgrant <[email protected]>
Co-authored-by: Owen Buckley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shelf label/chevron alignment issue when label is too long
2 participants