bug/issue 350 Fix website shelf collapse/expand event #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires #353 to work properly |
thescientist13
added
the
website
thescientist13
approved these changes
May 8, 2020
www/components/shelf/shelf.js
Outdated
| @@ -128,7 +128,7 @@ class Shelf extends LitElement { | |||
|
|
|||
| return html` | |||
| <li class="list-wrap"> | |||
| <a href="${item.link}" @click="${this.handleClick}"><h2 id="${id}">${item.label} <span>${chevron}</span></h2></a> | |||
| <a id="${id}" href="${item.link}" @click="${this.handleClick}"><h2>${item.label}</h2><span>${chevron}</span></a> | |||
There was a problem hiding this comment.
minor indentation change.
also, I think a block element (<h2>) technically isn't allowed inside an inline element (<a>). (I know not introduced by this PR but just commenting on it.)
There was a problem hiding this comment.
Well we might as well fix that while we're at it. A span would be valid.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #350 / #352
Summary of Changes
Adds
pointer-events:nonefor elements within the anchor element.