Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 220 puppeteer external requests #221

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Bug/issue 220 puppeteer external requests #221

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5631d2
lock down puppeteer request making
thescientist13 Oct 13, 2019
874a460
test for unexpected tracking files
thescientist13 Oct 13, 2019
5551cf2
loosen check
thescientist13 Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/cli/src/lib/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,28 @@ class Renderer {

async serialize(requestUrl) {
const page = await this.browser.newPage();
let response = null;

// Page may reload when setting isMobile
// https://github.com/GoogleChrome/puppeteer/blob/v1.10.0/docs/api.md#pagesetviewportviewport
page.evaluateOnNewDocument('customElements.forcePolyfill = true');
page.evaluateOnNewDocument('ShadyDOM = {force: true}');
page.evaluateOnNewDocument('ShadyCSS = {shimcssproperties: true}');

let response = null;
await page.setRequestInterception(true);

page.on('request', interceptedRequest => {
const interceptedRequestUrl = interceptedRequest.url();

if (
interceptedRequestUrl.indexOf('bundle.js') >= 0 || // webpack bundles, webcomponents-bundle.js
interceptedRequestUrl === requestUrl // pages / routes
) {
interceptedRequest.continue();
} else {
interceptedRequest.abort();
}
});

// Capture main frame response. This is used in the case that rendering
// times out, which results in puppeteer throwing an error. This allows us
Expand Down