Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/issue 220 puppeteer external requests #221

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Bug/issue 220 puppeteer external requests #221

merged 3 commits into from
Oct 15, 2019

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 13, 2019 •
edited
Loading

Related Issue

resolves #220

Summary of Changes

  1. From Enhancement/issue 9 polyfill using webcomponent loader #212 , introduced request interception to prevent unnecessary network requests. This prevents puppeteer from loading scripts and libraries (other than those we whitelist)
  2. Strength unit tests for script tags

Now now analytics code pre-loading in our generated output 👍
Screen Shot 2019-10-13 at 9 54 54 AM

@thescientist13 thescientist13 changed the base branch from master to release/0.4.0 October 13, 2019 13:59
@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP labels Oct 13, 2019
@thescientist13
Copy link
Member Author

thescientist13 commented Oct 13, 2019 •
edited
Loading

Screen Shot 2019-10-13 at 10 06 03 AM

Screen Shot 2019-10-13 at 10 06 16 AM

@thescientist13 thescientist13 added bug Something isn't working CLI P0 Critical issue that should get addressed ASAP and removed P0 Critical issue that should get addressed ASAP bug Something isn't working labels Oct 13, 2019
@thescientist13 thescientist13 merged commit caffa95 into release/0.4.0 Oct 15, 2019
@thescientist13 thescientist13 deleted the bug/issue-220-puppeteer-external-requests branch October 15, 2019 23:22
@thescientist13 thescientist13 mentioned this pull request Oct 15, 2019
Merged
thescientist13 added a commit that referenced this pull request Oct 16, 2019
@thescientist13
Bug/issue 220 puppeteer external requests (#221)
f3c158f 
* lock down puppeteer request making

* test for unexpected tracking files

* loosen check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant hutchgrant approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thescientist13 @hutchgrant