Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 은행명, 계좌 번호 응답 추가 #276

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Refactor: 은행명, 계좌 번호 응답 추가 #276

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
464ee1b
Add: 은행명, 계좌 번호 응답 추가
gitseoyeon Oct 15, 2024
3673799
Chore: CD 코드 수정
gitseoyeon Oct 15, 2024
8e30eb9
Chore: deploy 스크립트 실행
gitseoyeon Oct 15, 2024
2610441
Chore: CICD 설정 복구
gitseoyeon Oct 17, 2024
372d9c7
Merge: 부스 목록 조회에서의 행사 필터링 기능
gitseoyeon Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/gradle.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 이 부분은 어떤 이유로 바꾸신건지 알 수 있을까요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원래 작성했던 작업을 deploy.sh라는 배포 스크립트 안에 작성해서 작업을 수행할 때 스크립트 내용이 출력되도록 하기 위해 작성했습니다~ 현재 좀 더 수정해야하는 점이 있어서 이슈를 파서 더 수행할 예정입니다!

Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,9 @@ jobs:
username: ${{ secrets.USERNAME }}
port: 22
key: ${{ secrets.EC2_SSH_PRIVATE_KEY }}
envs: GITHUB_SHA
script: |
sudo docker rm -f $(docker ps -qa)
sudo docker pull ${{ secrets.DOCKER_USERNAME }}/openbook
docker-compose up -d
docker image prune -f
cd /home/ubuntu
./deploy.sh


# NOTE: The Gradle Wrapper is the default and recommended way to run Gradle (https://docs.gradle.org/current/userguide/gradle_wrapper.html).
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/com/openbook/openbook/api/booth/response/BoothDetail.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ public record BoothDetail(
String mainImageUrl,
LocalDateTime openData,
LocalDateTime closeData,
String accountNumber,
String accountBankName,
List<BoothAreaDto> location,
List<String> tags,
UserPublicResponse manager,
Expand All @@ -32,6 +34,8 @@ public static BoothDetail of(BoothDto booth){
booth.mainImageUrl(),
booth.openTime(),
booth.closeTime(),
booth.accountNumber(),
booth.accountBankName(),
booth.locations(),
booth.tags().stream().map(BoothTagDto::name).toList(),
UserPublicResponse.of(booth.manager()),
Expand Down
Loading