Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 은행명, 계좌 번호 응답 추가 #276

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

gitseoyeon
Copy link
Member

@gitseoyeon gitseoyeon commented Oct 15, 2024

Summary

Key Changes

  • 부스 단 건 조회시 계좌번호와 은행명을 응답하도록 데이터를 추가했습니다.

Testing

image

To Reviewers

  • 의견이나 질문 리뷰 남겨주세요!

@gitseoyeon gitseoyeon added the refactor 코드를 개선합니다. label Oct 15, 2024
@gitseoyeon gitseoyeon requested a review from muncool39 October 15, 2024 09:01
@gitseoyeon gitseoyeon self-assigned this Oct 15, 2024
Copy link
Member

@muncool39 muncool39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가 확인했습니다! 수고하셨습니다 👍
궁금한 점 하나 질문 남겼습니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 이 부분은 어떤 이유로 바꾸신건지 알 수 있을까요?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원래 작성했던 작업을 deploy.sh라는 배포 스크립트 안에 작성해서 작업을 수행할 때 스크립트 내용이 출력되도록 하기 위해 작성했습니다~ 현재 좀 더 수정해야하는 점이 있어서 이슈를 파서 더 수행할 예정입니다!

@gitseoyeon gitseoyeon merged commit 2ac3820 into dev Oct 17, 2024
2 checks passed
@gitseoyeon gitseoyeon deleted the refactor/#275 branch October 17, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드를 개선합니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 부스 상세 조회시 데이터 추가
2 participants