Fix test cache to consider MLD executable changes #6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the test cache is not invalidated if changes to osrm-partition or osrm-customize executables. This is problematic when these executables make breaking changes to the data format. We fix this by including both in the list of executables that can invalidate the test cache.
6 tasks
|
Confirmed this is working now. CI is loading the test cache from f1f9616 and invalidating it due to the changes. |
|
👍 |
|
Ugh, sorry that last commit was wrong. They should be underscores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently the test cache is not invalidated if changes are made to
osrm-partitionorosrm-customizeexecutables. This is problematic when these executables make breaking changes to the data format (e.g. #6124).We fix this by including both in the list of executables that can invalidate the test cache.
Tasklist